Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't use workspace inheritance for dev-dependencies #4097

Merged
merged 2 commits into from
Jun 20, 2023
Merged

chore: don't use workspace inheritance for dev-dependencies #4097

merged 2 commits into from
Jun 20, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Using workspace inheritance breaks cargo release because it cannot resolve that the dev-dependencies should only use a path and not a version.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added trivial Marks PRs which are considered trivial and don't need approval from another maintainer. send-it labels Jun 20, 2023
@mergify mergify bot merged commit 78c150d into master Jun 20, 2023
63 checks passed
@mergify mergify bot deleted the fix/no-inheritance-dev-dependencies branch June 20, 2023 12:24
mxinden
mxinden reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks! Looking forward to the next release.

umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
@thomaseizinger
chore: don't use workspace inheritance for dev-dependencies
5d89be8 
Using workspace inheritance breaks `cargo release` because it cannot resolve that the dev-dependencies should only use a `path` and not a version.

Pull-Request: libp2p#4097.


  
Co-Authored-By: Thomas Eizinger <thomas@eizinger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@mergify Mergify mergify approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden